feat(workspace): configure pull ignore paths - #15
Closed
mattzcarey wants to merge 2 commits into
Closed
Conversation
commit: |
aron-cf
reviewed
Jul 8, 2026
| // Omit to use the remote default (`node_modules`). A supplied list | ||
| // replaces that default; pass [] to pull every path. Pushes are | ||
| // unaffected. | ||
| ignore?: string[]; |
Collaborator
There was a problem hiding this comment.
I think probably for clarity it should be:
Suggested change
| ignore?: string[]; | |
| sync?: { ignore?: string[] }; |
Contributor
Author
|
Closing because agent-think will use full Workspace synchronization, including node_modules, rather than configuring generated-path exclusions. We will revisit the smaller default-sync behavior separately if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sync server already accepts an
ignorelist, butWorkspacecould not supply one. Commands such asnpm installcould therefore pull generated trees likedistand.cacheinto durable storage even though those files only need to exist on the execution backend.This adds
WorkspaceOptions.ignoreand passes it throughpullOnce()on every backend pull. Patterns match whole path segments. Omitting the option preserves the server default of["node_modules"]; a supplied list replaces that default, and[]disables filtering. Push behavior does not change.The capnweb wire test verifies that a custom list crosses the real transport and filters the pull. Workspace tests cover replacement of the default and the empty-list case.
npm testpasses, along with typechecks for the RPC, Workspace, and Think example packages. The package README, sync documentation, and Think example describe the behavior.After a release includes this option,
cloudflare/agentscan use one Workspace for durable files and command execution without pulling generated dependency and build trees into its Durable Object.